Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace structopt with clap in examples #3380

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jul 26, 2024

Replaces structopt with clap in examples.

@abonander
Copy link
Collaborator

@tottoto if you rebase it should fix CI.

@tottoto tottoto force-pushed the replace-structopt-with-clap branch from 5616045 to 6b297e4 Compare July 27, 2024 09:25
@tottoto
Copy link
Contributor Author

tottoto commented Jul 27, 2024

Rebased.

@jplatte
Copy link
Contributor

jplatte commented Jul 27, 2024

Just a random note that GitHub allows relaxing the default restriction on when workflow runs require approval (can't remember any PRs where not allowing them to run immediately was useful on this repo), in actions settings for the repo or organization:

Screenshot 2024-07-27 at 11-28-53 Actions settings · ruma

@abonander
Copy link
Collaborator

@jplatte I have mixed feelings about changing that option because I do skim PRs from new contributors before hitting the button, just to see if anyone's trying anything suspicious.

It doesn't really matter right now, but I could easily see myself adding a new workflow with sensitive tokens (e.g. an automated release workflow) and forgetting to properly gate it off.

I wish there was an option like "Approve and run all workflows for this PR" so I didn't have to keep doing it for the same PR though.

@abonander abonander merged commit 4ce181f into launchbadge:main Jul 27, 2024
70 checks passed
@tottoto tottoto deleted the replace-structopt-with-clap branch July 27, 2024 10:09
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants